Fix flow computation of HVDC connected at only one side #965

vidaldid-rte · 2024-01-23T17:27:27Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Yes : #953
This PR fixes the disconnection in situation N and completes #961

What kind of change does this PR introduce?

When one of the LfBus is missing in the LfNetwork, the HVDC status is determined by the IIDM Network.
If that bus is isolated, the HVDC does not flow any active power.
The determination is made before all LfBus are created for LCC stations - and thus contingencies that disconnect or reconnect an HDVC link with LCC station is still NOT SUPPORTED.

What is the current behavior?

Active power flows through an HVDC even if one of the stations is dandling in situation N.

What is the new behavior (if this is a feature change)?
If one of the stations of an HVDC line is dandling in situation N, no active power flows through it.

Does this PR introduce a breaking change or deprecate an API?

Yes
No

If yes, please check if the following requirements are fulfilled

The Breaking Change or Deprecated label has been added
The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

…ot). Signed-off-by: Anne Tilloy <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

# Conflicts: # src/test/java/com/powsybl/openloadflow/network/HvdcNetworkFactory.java

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java

src/main/java/com/powsybl/openloadflow/util/LfHvdcUtils.java

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

…erator...) and pinpoint limitation with current implementation Signed-off-by: VIDAL Didier (Externe) <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java

…ify test to use network monitors Signed-off-by: VIDAL Didier (Externe) <[email protected]>

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

…pen-loadflow into hvdc-loss-in-N

Signed-off-by: Anne Tilloy <[email protected]>

src/main/java/com/powsybl/openloadflow/util/LfHvdcUtils.java

src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowVscTest.java

jeandemanged · 2024-01-29T11:19:20Z

src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowVscTest.java

+        assertTrue(pcs2 == 0 || Double.isNaN(pcs2), "HVDC Station should not generate power " + network.getHvdcConverterStation("cs2").getTerminal().getP());
+        assertTrue(pcs3 == 0 || Double.isNaN(pcs3), "HVDC Station should not generate power");


Note: we get 0MW for VSC and NaN for LCC, we might leave like this for now but add a comment/note here because it is not straightforward / it is inconsistent today in OLF

Agreed, and I am not sure it is the good solution to put NaN.

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java

jeandemanged · 2024-01-29T11:25:32Z

src/main/java/com/powsybl/openloadflow/network/impl/Networks.java

+    public static boolean isIsolatedBusForHvdc(LfBus bus, GraphConnectivity<LfBus, LfBranch> connectivity) {
+        // used only for hvdc lines.
+        // this criteria can be improved later depending on use case
+        return connectivity.getConnectedComponent(bus).size() == 1 && bus.getLoadTargetP() == 0.0
+                && bus.getGenerators().stream().noneMatch(LfGeneratorImpl.class::isInstance);
+    }


no SA test covering this

jeandemanged · 2024-01-29T11:30:44Z

I would rename the PR to something like Fix flow computation of HVDC connected at only one side

Signed-off-by: Anne Tilloy <[email protected]>

annetill · 2024-01-29T14:57:21Z

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java

@@ -285,7 +285,11 @@ void addLoad(Load load, LfNetworkParameters parameters) {
    }

    void addLccConverterStation(LccConverterStation lccCs, LfNetworkParameters parameters) {
-        getOrCreateLfLoad(null, parameters).add(lccCs, parameters);
+        if (!HvdcConverterStations.isHvdcDanglingInIidm(lccCs, parameters)) {


Because of that, we end the calculation with NaN as p for the converter station for LCC only. @jeandemanged I don't like it very much...

Signed-off-by: Anne Tilloy <[email protected]>

sonarqubecloud · 2024-01-29T15:48:47Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
90.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jeandemanged

It is very fine enough for now, thanks

annetill added 3 commits January 21, 2024 15:33

Proposal to handle lost of a VSC converter station (ac emulation or n…

68fa131

…ot). Signed-off-by: Anne Tilloy <[email protected]>

Fix dc sensi. Bus contingency still missing...

01e3fa7

Signed-off-by: Anne Tilloy <[email protected]>

Clean after sonar analysis.

9df1b92

Signed-off-by: Anne Tilloy <[email protected]>

vidaldid-rte requested review from annetill and rosiereflo January 23, 2024 17:27

geofjamg and others added 5 commits January 24, 2024 09:47

Merge branch 'main' into rework-hvdc

b5e099e

# Conflicts: # src/test/java/com/powsybl/openloadflow/network/HvdcNetworkFactory.java

Fix

79db2b4

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Clean comment.

9b7b84d

Signed-off-by: Anne Tilloy <[email protected]>

Refactoring.

10d1976

Signed-off-by: Anne Tilloy <[email protected]>

Support HVDC disconnection in IIDM network

78dcfe7

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

vidaldid-rte force-pushed the hvdc-loss-in-N branch from c8c3cd2 to 78dcfe7 Compare January 24, 2024 12:42

rosiereflo requested changes Jan 24, 2024

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java Outdated Show resolved Hide resolved

PR review + typos

365e5e4

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

rosiereflo approved these changes Jan 25, 2024

View reviewed changes

Base automatically changed from rework-hvdc to main January 25, 2024 09:49

Merge branch 'main' into hvdc-loss-in-N

0a25a81

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

vidaldid-rte changed the title ~~[WIP] Support HVDC disconnection in IIDM network~~ Support HVDC disconnection in IIDM network Jan 25, 2024

vidaldid-rte mentioned this pull request Jan 25, 2024

Issue with HDVC AC computation when output terminal is disconnected #953

Open

annetill reviewed Jan 25, 2024

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java Outdated Show resolved Hide resolved

annetill reviewed Jan 25, 2024

View reviewed changes

src/main/java/com/powsybl/openloadflow/util/LfHvdcUtils.java Outdated Show resolved Hide resolved

annetill reviewed Jan 25, 2024

View reviewed changes

src/main/java/com/powsybl/openloadflow/util/LfHvdcUtils.java Outdated Show resolved Hide resolved

vidaldid-rte added 2 commits January 26, 2024 10:48

fix typo

99df3ae

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

backport test from PR 957

063e0b7

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

vidaldid-rte force-pushed the hvdc-loss-in-N branch from 06495a8 to 063e0b7 Compare January 26, 2024 09:49

vidaldid-rte and others added 2 commits January 26, 2024 11:48

adapt test to factory (in the factory thehvdc pushes power to the gen…

d4f86f5

…erator...) and pinpoint limitation with current implementation Signed-off-by: VIDAL Didier (Externe) <[email protected]>

Fix N state restoration.

0c1a72b

Signed-off-by: Anne Tilloy <[email protected]>

annetill reviewed Jan 26, 2024

View reviewed changes

src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java Outdated Show resolved Hide resolved

vidaldid-rte and others added 3 commits January 26, 2024 15:40

Align isolated bus in IIDM with Networks.isIsolatedBusForHvdc and mod…

6cbcd3e

…ify test to use network monitors Signed-off-by: VIDAL Didier (Externe) <[email protected]>

Merge branch 'main' into hvdc-loss-in-N

8b43547

Signed-off-by: VIDAL Didier (Externe) <[email protected]>

Add a unit test and fix code smells.

78a8497

Signed-off-by: Anne Tilloy <[email protected]>

Merge branch 'hvdc-loss-in-N' of https://github.com/powsybl/powsybl-o…

b74239b

…pen-loadflow into hvdc-loss-in-N

annetill added the PR: next-release label Jan 26, 2024

Add unit test.

dca7925

Signed-off-by: Anne Tilloy <[email protected]>

annetill requested review from Hadrien-Godard and geofjamg January 26, 2024 16:51

Merge branch 'main' into hvdc-loss-in-N

1ad88db

jeandemanged requested changes Jan 29, 2024

View reviewed changes

annetill added 2 commits January 29, 2024 12:56

Move utility method.

1875d34

Signed-off-by: Anne Tilloy <[email protected]>

Fix unit test (1).

d930f03

Signed-off-by: Anne Tilloy <[email protected]>

annetill reviewed Jan 29, 2024

View reviewed changes

annetill and others added 2 commits January 29, 2024 16:29

Clean unit test (2).

e598e51

Signed-off-by: Anne Tilloy <[email protected]>

Merge branch 'main' into hvdc-loss-in-N

d9193e4

annetill changed the title ~~Support HVDC disconnection in IIDM network~~ Fix flow computation of HVDC connected at only one side Jan 29, 2024

jeandemanged approved these changes Jan 29, 2024

View reviewed changes

jeandemanged merged commit ebd343d into main Jan 30, 2024
6 checks passed

jeandemanged deleted the hvdc-loss-in-N branch January 30, 2024 09:07

annetill mentioned this pull request Feb 1, 2024

[WIP] Hvdc and disconnect #957

Closed

7 tasks

vidaldid-rte mentioned this pull request Nov 14, 2024

fictive load on isolated bus keeps hvdc isolated #1120

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix flow computation of HVDC connected at only one side #965

Fix flow computation of HVDC connected at only one side #965

vidaldid-rte commented Jan 23, 2024 •

edited by jeandemanged

Loading

jeandemanged Jan 29, 2024

annetill Jan 29, 2024

jeandemanged Jan 29, 2024

jeandemanged commented Jan 29, 2024

annetill Jan 29, 2024

sonarqubecloud bot commented Jan 29, 2024

jeandemanged left a comment

		assertTrue(pcs2 == 0 \|\| Double.isNaN(pcs2), "HVDC Station should not generate power " + network.getHvdcConverterStation("cs2").getTerminal().getP());
		assertTrue(pcs3 == 0 \|\| Double.isNaN(pcs3), "HVDC Station should not generate power");

Fix flow computation of HVDC connected at only one side #965

Fix flow computation of HVDC connected at only one side #965

Conversation

vidaldid-rte commented Jan 23, 2024 • edited by jeandemanged Loading

jeandemanged Jan 29, 2024

Choose a reason for hiding this comment

annetill Jan 29, 2024

Choose a reason for hiding this comment

jeandemanged Jan 29, 2024

Choose a reason for hiding this comment

jeandemanged commented Jan 29, 2024

annetill Jan 29, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 29, 2024

Quality Gate passed

jeandemanged left a comment

Choose a reason for hiding this comment

vidaldid-rte commented Jan 23, 2024 •

edited by jeandemanged

Loading